opencryptoki / openssl-ibmca

OpenSSL engine and provider for libica.
Apache License 2.0
7 stars 15 forks source link

Add AES-GCM support. #11

Closed p-steuer closed 7 years ago

p-steuer commented 7 years ago

Add AES-GCM support to ibmca.

Code builts with with OpenSSL versions < and >= 1.1.0. Test suite's AES-GCM test vectors pass, but the patches still needs a carefull review, because all the messy ifdefs ... Do we have test cases for the engine ?

p-steuer commented 7 years ago

i agree in all points. reworked the code to work completely without openssl version ifdefs by introducting compability macros -- looks much cleaner now

pvital commented 7 years ago

Reviewed-by: Paulo Vital pvital@linux.vnet.ibm.com