opencryptoki / openssl-ibmca

OpenSSL engine and provider for libica.
Apache License 2.0
6 stars 15 forks source link

Fix/bz192017 #64

Closed juergenchrist closed 3 years ago

juergenchrist commented 3 years ago

Various fixes and tests for bz192017. Fix for a clang compile warning.

Open Point: Should we bump the bugfix part of the version number?

juergenchrist commented 3 years ago

Only one concern: the _atomic* functions are GCC only.

I tested with GCC and clang. Both know the _atomic* functions. Are we worried about yet another compiler?

juergenchrist commented 3 years ago

We could use CRYPTO_atomic_add from libcrypto. This needs a CRYPTO_RWLOCK, but otherwise it seems to boil down to similar code. Will change.

juergenchrist commented 3 years ago

New version now uses libcrypto to handle atomicity. Got way more complicated though...