search

opencryptoki / openssl-ibmca

OpenSSL engine and provider for libica.
Apache License 2.0
6 stars 15 forks source link

Skip eckey test if needed. #70

Closed juergenchrist closed 3 years ago

juergenchrist commented 3 years ago

Without crypto cards on a machine < z14, ibmca might not register with the EC_KEY subsystem of OpenSSL. In these cases, the eckey test should be skipped since it is doomed to fail.

Fixes #69.

Signed-off-by: Juergen Christ jchrist@linux.ibm.com

jschmidb commented 3 years ago

lgtm. I think we cannot do anything else. Dan is right with <z15 or <=z14.

juergenchrist commented 3 years ago

Yes, you are right. Fixed that comment.

sharkcz commented 3 years ago

For the record, the eckey test is skipped with this patch on my z14.

sharkcz commented 3 years ago

it has z155555 now, looks like auto-repeat in action :-)

juergenchrist commented 3 years ago

it has z155555 now, looks like auto-repeat in action :-)

Fixed. Still checking why I did not get any notification about your first comment. Seems like something is wrong with my github settings...

juergenchrist commented 3 years ago

the eckey test is skipped with this patch on my z14.

Well, it gets even more complicated to draw the correct matrix. It is something like

On z14 or older without CCA card the eckey test is skipped. On z15 wihout CCA card but with libica-cex the test is skipped. Otherwise it should get executed.

juergenchrist commented 3 years ago

I will not produce a new release for this. It will go into the next upcoming release.

sharkcz commented 3 years ago

no problem, I will cherry-pick the fix