search

openculinary / frontend

The RecipeRadar Frontend is a recipe search and meal planning application
GNU Affero General Public License v3.0
13 stars 2 forks source link

d3-sankey is in a private repository. #185

Closed webgem-jpl closed 3 years ago

webgem-jpl commented 3 years ago

Describe the bug It is currently impossible to install node.js dependencies because "d3-sankey" is from a private repository.

To Reproduce Steps to reproduce the behavior:

  1. Without access to: "github:jayaddison"
  2. npm install --also=dev

Expected behavior All node.js dependencies should be installable.

jayaddison commented 3 years ago

Hi @webgem-jpl - the package dependency on jayaddison/d3-sankey refers to a public fork of the original d3-sankey, so I'm surprised it appears private to you - can you provide a few more details?

jayaddison commented 3 years ago

Closing this for now; please feel free to comment with more details and re-open if the installation issue's still occurring.

jayaddison commented 3 years ago

This issue has been verified; basically it turns out that this appears as an npm install-time error message indicating a possible permissions/access issue.

I think we'll be able to switch back to using an HTTPS-based repository clone approach.

jayaddison commented 3 years ago

@webgem-jpl fwiw, I think https://github.com/npm/cli/issues/2389 is the upstream issue for this if you'd like to follow resolution

jayaddison commented 3 years ago

Just to clarify a little for the record: the issue isn't that this frontend repository is private; it's not, or certainly shouldn't be - it's a public repository.

The issue is that npm is attempting to use SSH key-based authentication (instead of anonymous HTTPS access) via git when retrieving the d3-sankey module contents from the repository. This leads to problems on systems that do not have SSH client authentication keys configured for requests to GitHub.

One alternative would be to post a version of d3-sankey to the NPM package repository under an alternate name, but generally that seems like it could mislead people; I'd prefer if we could upstream the fixes required to render sankey diagrams vertically and then upgrade to use an officially-packaged release of d3-sankey.