openculinary / frontend

The RecipeRadar Frontend is a recipe search and meal planning application
GNU Affero General Public License v3.0
13 stars 2 forks source link

Allow the comma character to act as a separator during ingredient entry #210

Closed jayaddison closed 11 months ago

jayaddison commented 2 years ago

Is your feature request related to a problem? Please describe. It's relatively common in text-based input systems to use a comma (,) as a separator between values (derived from the fact that it's frequently used as a separator when lists of items are written in English).

Describe the solution you'd like Writing a comma character into the ingredient input boxes should indicate that the user has completed entry of one ingredient and is moving on to the next. This may mean that it acts the same way that pressing the 'enter' or 'tab' key currently does; it should place the currently-highlighted ingredient from autosuggest into the input field, and allow the user to begin typing a new ingredient name.

jayaddison commented 11 months ago

With apologies to the requester (PhillyG) - I'm not planning to make this change at the moment, but that could be revisited in future if there are additional asks for it (and some supporting reasoning).

Roughly speaking, I don't think this is necessary because the search-to-redirect rate in the service appears acceptable-enough at the moment (between 5-10%), and there hasn't been any other feedback about the lack of comma-as-selection-character being a problem. In addition, allowing it to be would be a(nother) customisation of the select2 control -- and as far as possible I'd like us to continue using the vanilla select2 implementation (we have a few customizations at the moment; I'd prefer to reduce and remove those to bring us nearer to a standard configuration).