search

openculinary / frontend

The RecipeRadar Frontend is a recipe search and meal planning application
GNU Affero General Public License v3.0
13 stars 2 forks source link

Developer experience: enable additional linting rules #238

Closed jayaddison closed 1 year ago

jayaddison commented 1 year ago

Describe the reason for these changes and the problem that they solve

Enables some additional linting rules provided by @typescript-eslint (in fact, enables the recommended-type-checked base ruleset, but with a few items selectively disabled). This is done to catch more errors (particularly datatype-related errors) earlier during the development lifecycle.

Briefly summarize the changes

  1. Enable the recommended-type-checked ruleset in the project's eslintrc.
  2. Disable a few rules that have a combination of high frequency with low value throughout the codebase.

How have the changes been tested?

  1. make lint has been used to check that the rules are enabled and that the lint tooling considers that the codebase adheres to them.

List any issues that this change relates to N/A

jayaddison commented 1 year ago

Note for transparency: this pull request also disables eslint checks for all code within the service-worker submodule (src/sw/*). That's 49 lines of code that has been stable for a year and is not written in TypeScript.. even so, it'd be nice to lint that again at some point (it's important, but infrequently modified code).