openculinary / knowledge-graph

The RecipeRadar knowledge graph stores and provides access to recipe and ingredient relationship information.
GNU Affero General Public License v3.0
10 stars 0 forks source link

Use shared hashedindex library #38

Closed jayaddison closed 4 years ago

jayaddison commented 4 years ago

Describe the reason for these changes and the problem that they solve

The functionality previously implemented in the knowledge-graph to perform search-related operations is now available on PyPI as hashedixsearch.

We can now switch to use that common library and remove a bunch of search-specific code from the knowledge-graph service.

The one feature lost (since it does not easily generalize to other applications) is the addition of an href attribute on marked-up query results. That's a feature that can be re-evaluated and potentially restored elsewhere; it's not currently in use.

jayaddison commented 4 years ago

Tested via existing unit test coverage, and by performing a hierarchy update locally (pipenv run python -m scripts.hierarchy --update)