openculinary / knowledge-graph

The RecipeRadar knowledge graph stores and provides access to recipe and ingredient relationship information.
GNU Affero General Public License v3.0
10 stars 0 forks source link

Equipment names may unexpectedly be extracted in pluralized form #62

Closed jayaddison closed 3 years ago

jayaddison commented 3 years ago

Describe the bug Although we correctly match the text slow cookers in recipe direction text against the equipment name slow cooker, it seems that we store and index the pluralized slow cookers item name in some cases.

Screenshot image

To Reproduce Steps to reproduce the behavior:

$ $ curl --silent 192.168.100.1:9200/recipes/_doc/jCxMehkRj5VR6bbfWzFU23d1LwHwZNMpbXC | jq ._source.directions[].equipment
[
  {
    "equipment": "slow cooker"
  }
]
[
  {
    "equipment": "slow cooker"
  },
  {
    "equipment": "slow cookers"
  }
]
[]

Expected behavior slow cooker should appear in the equipment lists, but slow cookers should not.

jayaddison commented 3 years ago

This has been resolved thanks to the linked pull requests.