[feat]tools-v2: add bs recover volume

opencurve / curve

Curve is a sandbox project hosted by the CNCF Foundation. It's cloud-native, high-performance, and easy to operate. Curve is an open-source distributed storage system for block and shared file storage.

https://opencurve.io

Apache License 2.0

2.33k stars 522 forks source link

[feat]tools-v2: add bs recover volume #2936

Closed CrystalAnalyst closed 10 months ago

CrystalAnalyst commented 11 months ago

What problem does this PR solve?

Issue Number: #2588

Problem Summary: add recover as a middle command, and it has sub-command volume.

What is changed and how it works?

What's Changed: add recover middle command directory, and subcommand directory volume.

How it Works: recover.go is the middle command. Inside the sub-direcotry volume , the volume.go is the final command, while the recover.go wraps the RecoverFilePRC to execute the real recover procedure.

Side effects(Breaking backward compatibility? Performance regression?):

Check List

[yes] Relevant documentation/comments is changed or added
[yes] I acknowledge that all my contributions will be made under the project's license

baytan0720 commented 10 months ago

@caoxianfei1 PTAL

baytan0720 commented 10 months ago

cicheck

baytan0720 commented 10 months ago

cicheck

caoxianfei1 commented 10 months ago

@CrystalAnalyst need rebase otherwise ci may fail.

CrystalAnalyst commented 10 months ago

cicheck

CrystalAnalyst commented 10 months ago

cicheck

CrystalAnalyst commented 10 months ago

cicheck

caoxianfei1 commented 10 months ago

@CrystalAnalyst please fix the conflict.

montaguelhz commented 10 months ago

Use rebase instead of merge.

montaguelhz commented 10 months ago

Also, it might be better to leave a blank line between the comment and the code.

CrystalAnalyst commented 10 months ago

Also, it might be better to leave a blank line between the comment and the code.

okay.

CrystalAnalyst commented 10 months ago

Use rebase instead of merge.

yes, I reset to previous commit and use rebase solved the conflict justnow.

caoxianfei1 commented 10 months ago

the commit message suggestion is: Feat/tool: add command recover volume

caoxianfei1 commented 10 months ago

cicheck

CrystalAnalyst commented 10 months ago

cicheck

baytan0720 commented 10 months ago

cicheck

caoxianfei1 commented 10 months ago

LGTM!

CrystalAnalyst commented 10 months ago

cicheck

CrystalAnalyst commented 10 months ago

All checks have passed. Is there anyone who is authorized to help me merge this pull request ? @caoxianfei1 @montaguelhz @baytan0720 I'd appreciate that, thanks.