[Fix](common): fix arc cache capacity && add some tests

opencurve / curve

Curve is a sandbox project hosted by the CNCF Foundation. It's cloud-native, high-performance, and easy to operate. Curve is an open-source distributed storage system for block and shared file storage.

https://opencurve.io

Apache License 2.0

2.32k stars 521 forks source link

[Fix](common): fix arc cache capacity && add some tests #2953

Closed zztaki closed 8 months ago

zztaki commented 9 months ago

What problem does this PR solve?

Issue Number: #2952

Problem Summary: ARCCache cache capacity shoule be maxCount and there is a lack of ARC related tests here.

What is changed and how it works?

What's Changed: adjust ARC cache capacity to maxCount and add some tests.

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

[x] Relevant documentation/comments is changed or added
[x] I acknowledge that all my contributions will be made under the project's license

zztaki commented 9 months ago

cicheck

zztaki commented 9 months ago

cicheck

zztaki commented 9 months ago

cicheck

zztaki commented 9 months ago

cicheck

wuhongsong commented 9 months ago

@skypexu PTAL？

skypexu commented 9 months ago

It was fixed in recent commits.

@skypexu PTAL？

skypexu commented 9 months ago

Yes, you can improve ARC unittest futher if you wish.

zztaki commented 9 months ago

A bit unluck for having been fixed recently. Maybe I can try other modules :)