opencurve / curve

Curve is a sandbox project hosted by the CNCF Foundation. It's cloud-native, high-performance, and easy to operate. Curve is an open-source distributed storage system for block and shared file storage.
https://opencurve.io
Apache License 2.0
2.32k stars 521 forks source link

Fix side effect of Remove operation. #2961

Closed skypexu closed 9 months ago

skypexu commented 9 months ago

In the original ARC paper, there was no explanation of how Remove should be handled when the cache is full. The Remove operation would have a side effect on subsequent Put operations when the cache is not full, which is still evicting items even though it's clear that there is no need to evict when the cache is not full.

Now, code has been added to check if the cache is full to avoid performance degradation.

Also fix c_, it should be max_count. Also add unittest.

What problem does this PR solve?

Issue Number: #2962

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

wuhongsong commented 9 months ago

cicheck

skypexu commented 9 months ago

cicheck

skypexu commented 9 months ago

cicheck

skypexu commented 9 months ago

cicheck