Important Fixes

[maxizu]

-updating the ImageViewer and the UI from main thread -Mat to Image fix -Better way running a thread -Settings

[luigidr]

Hi again, @maxizu,

thanks for the pull request.

I'm sorry but I will not merge your commits to the getting-started project for various reasons. Obviously, the issues you previously opened and solved here are more than appreciated.

The main reason for this "rejection" is that the current state of your project is moving away from a getting started project to something more advanced and "sophisticated". I see the getting-started as a first, minimal, example to - well - get started with OpenCV and JavaFX. Your commit ab7958c ("Due to the big changes, I started my own fixed project") probably is a different way to say the same thing.

There are some other (minor!) reasons:

• Java conventions are not always respected, e.g., variable names are camelCase, so fps_avgof (and others) is not "conventional"; method names start with a lower letter, so OpenSettingsWindow() (and others) is not "correct"; etc.
• Commented code should be avoided, if not strictly necessary.
• Sometimes, exceptions could be handled/logged more precisely than the default e.printStackTrace().
• The name of the package should differ from com.opencv, since I don't own the opencv.com domain nor I am affiliated with the OpenCV organization (see Naming a Package from the Java Tutorials). Mainly, it is for avoiding confusion and "issues" with the official OpenCV organization.
• ...

I think that your solution could be a better fit for the video-basics project or for an additional repository "halfway" between this project and video-basics. What do you think? These repositories serve as companion for the tutorials hosted on readthedocs: relevant changes should be reported in the documentation, too.

Given your interest in the topic, since this organization starts out from the solutions of a university-level Computer Vision course in Italy and it is somewhat "limited" to the course content, do you like/want to contribute to the organization as a member? Currently, I am the only maintainer of the projects and the organization is structured according the course content (this can change). If you are interested, please, send me an e-mail so that we can continue this discussion in a more private form! ;)

[maxizu]

Hey @luigidr , sorry i made a git mistake ;) The git pull request should be only for this commit
I commited some more features and fixes to the newer commits with the points described. I know that there some improvements to the newer commits but i just coded that within 30min at my lunch break. Howsoever thanks for your improvments :+1:

Commit "Fixed Window resize" fixes #3 and #2 and added a fix for automatic window resizeing might be a good pull request. This request was just a complete fixed code for you for a nice overview.

Would be happy to continue the discussion. Feel free to contact me at kontakt@max-z.de

[luigidr]

Hi @maxizu,

no problem for your "git mistake". :)

I manually merged your first 2 commits to close issues #2 and #3.