opencv / ade

Apache License 2.0
59 stars 49 forks source link

Add build static option #18

Closed baizebing closed 1 year ago

baizebing commented 4 years ago

Sometimes a static version is needed, just for convenience.

Signed-off-by: baizebing zebing.bai@intel.com

baizebing commented 4 years ago

In our project, we need a inference_engine.dll which should be a universal driver dll. So, a static version is needed.

dmatveev commented 4 years ago

In our project, we need a inference_engine.dll which should be a universal driver dll. So, a static version is needed

Please note that IE is already using (and so exposing ADE), isn't it static there?

baizebing commented 4 years ago

In our project, we need a inference_engine.dll which should be a universal driver dll. So, a static version is needed

Please note that IE is already using (and so exposing ADE), isn't it static there?

No, by default it links to dynamic CRT, and I have to change the CRT version manually when I want universal version. OpenCV is quite convenient :)

mshabunin commented 4 years ago

I guess, we just need to rename BUILD_STATIC to BUILD_WITH_STATIC_CRT in this PR and it will be OK.

dmatveev commented 4 years ago

I guess, we just need to rename BUILD_STATIC to BUILD_WITH_STATIC_CRT in this PR and it will be OK.

Sounds reasonable!

@baizebing would you do that please? Thanks!

dmatveev commented 1 year ago

@baizebing is this issue still relevant?

dmatveev commented 1 year ago

@Hardcode84 can you please have a look at the build failure?

https://github.com/opencv/ade/runs/7826403639?check_suite_focus=true

I believe it is irrelevant to the changes in MR, but anyway

dmatveev commented 1 year ago

I guess, we just need to rename BUILD_STATIC to BUILD_WITH_STATIC_CRT in this PR and it will be OK.

Done

baizebing commented 1 year ago

I haven't tried that for years. If it can be a universal library, it would be great.

dmatveev commented 1 year ago

@baizebing thanks for the follow-up! just merged it with a renamed option.