Don't override CMAKE_CXX_STANDARD set by parent projects

opencv / ade

Apache License 2.0

61 stars 50 forks source link

Don't override CMAKE_CXX_STANDARD set by parent projects #40

Closed ilya-lavrenov closed 12 months ago

ilya-lavrenov commented 12 months ago

When ADE used as a submodule, it overrides CMAKE_CXX_STANDARD set by parent project. E.g. parent projects defines CMAKE_CXX_STANDARD as 14 and during first cmake run it's applied, but during second cmake run ADE's value is used from cache. No needs to keep CMAKE_CXX_STANDARD in cache, because it may vary from project to project.

dmatveev commented 12 months ago

Fixing build in #41

dmatveev commented 12 months ago

Messed up with ctest, #42 is the fix

dmatveev commented 12 months ago

It seems the current Actions setup doesn't put patch atop of the master but tests the original branch itself, @ilya-lavrenov can you please pull the latest master in?