Open ZelboK opened 1 month ago
I ran the precommit hook, but it is highlighting a lot of formatting related problems. Is there a simple fix for this?
@ZelboK thanks for the patch. General comments:
opencv_extra/testdata/dnn
to download 3rdparty models for testing. Please use it to achieve full dnn coverage locally.@asmorkalov
opencv_test_dnn
opencv_test_core
opencv_perf_dnn
opencv_sanity_dnn
All pass. Updated to remove the formatting problems.
Also, is there no formatting hook I could run to do all the formatting automatically for me?
The PR breaks CuDNN 8 (v 8.7.0, Ubuntu 18.04):
The PR breaks CuDNN 8 (v 8.7.0, Ubuntu 18.04):
it was because the PR is incomplete. Some variables not exists as input_size. This modules need to refactored
A lot of APIs that are currently being used in the dnn module have been removed in cudnn 9. They were deprecated in 8. This PR updates said code accordingly to the newer API.
Some key notes: 1) This is my first PR. I am new to openCV. 2)
opencv_test_core
tests pass 3) On a 3080, cuda 12.4(should be irrelevant since I didn't build theopencv_modules
, gcc 11.4, WSL 2. 4) For brevity I will avoid including macro code that will allow for older versions of cudnn to build.I was unable to get the tests working for
opencv_test_dnn
andopencv_perf_dnn
. The errors I get are of the following:So before I spend more time investigating I was hoping to get a maintainer to point me in the right direction here. I would like to run these tests and confirm things are working as intended. I may have missed some details.
Pull Request Readiness Checklist
relevant issue (https://github.com/opencv/opencv/issues/24983