HAL mul8x8to16 added - Githubissues

opencv / opencv

Open Source Computer Vision Library

https://opencv.org

Apache License 2.0

75.95k stars 55.61k forks source link

HAL mul8x8to16 added #25506

Open savuor opened 2 weeks ago

savuor commented 2 weeks ago

fixes #25034

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

[x] I agree to contribute to the project under Apache 2 License.
[x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
[x] The PR is proposed to the proper branch
[x] There is a reference to the original bug report and related work
[x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.
[x] The feature is well documented and sample code can be built with the project CMake

vpisarev commented 2 days ago

Can we replace getMulTab(bool extended) function with getMulFunc(int src1depth, int src2depth, int dstdepth)? We can pass such a function into arithm_op. arithm_op will first try to get direct function for the original src1, src2 and dst depths and if it fails, it will make another try with normalized types (in the latter case the explicit conversion 8u->32f is done for each of the inputs in the case of 8u x 8u -> 32f op).