BRISQUE: empty don't works as expected

[Nuzhny007]

System information (version)

• OpenCV => 4.3
• Operating System / Platform => Windows 64 Bit
• Compiler => Visual Studio 2017

  Detailed description

When I create QualityBRISQUE with wrong path to the range file the QualityBRISQUE::create returns a valid pointer. Ho can I check that all data was loaded correctly? I call QualityBase::empty - but it always returns true: https://github.com/opencv/opencv_contrib/blob/master/modules/quality/include/opencv2/quality/qualitybase.hpp#L49

May be it can add overloaded method empty to the QualityBRISQUE? And if model or range was not loaded correctly than it will return true: CV_WRAP bool empty() const CV_OVERRIDE { return _range.empty() || _model.empty(); }

[alalek]

/cc @clunietp

[clunietp]

Thanks @Nuzhny007 - IIRC the constructor would throw an exception if the range file was empty, but apparently either I am mistaken or that behavior has changed. Regardless, I agree there should be a fix. Are you still going to pursue your PR?

My original intent was to throw an exception on invalid files (thus never leaving the brisque obj in an invalid state), but I can see no harm in implementing empty() as well

[Nuzhny007]

Now I can set the wrong path to the range file and it will be exception in compute(). I was about to make PR, but the tests failed. Can you see what is wrong with them?

[clunietp]

When you fork, you need to create a new branch as well in your repo. You need to create a new branch in your repo, and then initiate a PR to opencv:master from that. Make sense?

Also, in your empty() method, you may also want to check for _model != nullptr (or similar) prior to checking _model.empty(). Eg: return _range.empty() || !_model || _model.empty();

[Nuzhny007]

Ok: https://github.com/opencv/opencv_contrib/pull/2565