ovis: example: remove opencv_aruco

opencv / opencv_contrib

Repository for OpenCV's extra modules

Apache License 2.0

9.19k stars 5.74k forks source link

ovis: example: remove opencv_aruco #3733

Closed Kumataro closed 1 month ago

Kumataro commented 2 months ago

Close #3732 Related https://github.com/opencv/opencv/issues/23329

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

[x] I agree to contribute to the project under Apache 2 License.
[x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
[x] The PR is proposed to the proper branch
[x] There is a reference to the original bug report and related work
[ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name.
[ ] The feature is well documented and sample code can be built with the project CMake

Kumataro commented 2 months ago

One ideal is to modify the source code so that the build will pass. However, the issues blocking this build did not surface 1 year after https://github.com/opencv/opencv/issues/23329 .

Therefore, I think it is appropriate to disable this sample code.

asmorkalov commented 1 month ago

@AleksandrPanov could you handle this? The sample update should be relatively easy.

Kumataro commented 1 month ago

Thank you for your comment !

The sample update should be relatively easy.

Updating this sample program suitabled for OpenCV4.x is better than this pull request.

I investigated this problem at 2023/5, so perhaps this result may be incorrect in after OpenCV 4.9.0.

https://github.com/opencv/opencv/issues/23329#issuecomment-1461705535

aruco module is moved between opencv and opencv_contrib in OpenCV 4.7.0 URL. In this time, some functions had been deprecated,, and some functions lost backcompatibility.

And I had created temporary patch to build it, but I couldn't test it (I had/have no camera to test it). I hope this information is of some help.

opencv-alalek commented 1 month ago

replaced by #3735