opencybersecurityalliance / cacao-roaster

A web application for generating, parsing and validating, manipulating, and visualizing CACAO v2.0 playbooks.
Other
18 stars 7 forks source link

Exporting a playbook that was imported generates a completely new playbook while should consider playbook versioning #15

Open lucamrgs opened 3 months ago

lucamrgs commented 3 months ago

When a playbook is imported, modified, and exported, the exported playbook is considered a new playbook altogether.

It would be nice if a prompt asked if the exported playbook should be an update on the imported playbook, and manage the playbook version and related properties (time created, time modified) accordingly.

mateusdz commented 3 months ago

Most probably this is happening since the Roaster populates the creator identifier automatically. Therefore, an exported playbook that is imported (in a refreshed/page reloaded) Roaster has a different identifier. Then, you are not creator of this playbook and therefore a new playbook (and a derived from embedded relationship) is created.

(However, recently, I became aware of a bug with the identifier, which may cause confusion on this front as well.) Leaving this issue open until further investigation with the identifier.