opendataConcordiaU / documentation

Documentation and examples on the use of Concordia University open data API
36 stars 4 forks source link

Library Hours Endpoint Error #10

Closed markjamesm closed 2 years ago

markjamesm commented 3 years ago

Hi,

I've been receiving errors when attempting to access the library hours endpoint using today or yesterday's date:

https://opendata.concordia.ca/API/v1/library/hours/2020-10-20

Returns the following:

[{"service":"Webster Library","text":"7 PM to 7 PM"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"service":"Vanier Library","text":"7 PM to 7 PM"},{"Error":"Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"},{"service":"Grey Nuns","text":"7 PM to 7 PM"}]

volovikariel commented 2 years ago

This seems to be working fine now, some endpoints may not be available, but almost all of them seem to work.

Maybe the API shouldn't return the error-only objects because it's hard to tell what they map to (which service). Or perhaps an object of this form should be used instead? {"service": "service_name", "text": "ERROR ..."}

I'm writing this as of April 6 2022, and I tested April 30 2022 (link: https://opendata.concordia.ca/API/v1/library/hours/2022-04-30).

[
{
"service": "Webster Library",
"text": "2 PM to 2 PM"
},
{
"service": "Reference Desk",
"text": "12 PM to 5 PM"
},
{
"service": "Loans and Returns",
"text": "10 AM to 5 PM"
},
{
"service": "Interlibrary Loans",
"text": "2 PM to 2 PM"
},
{
"service": "Technology Sandbox",
"text": "2 PM to 2 PM"
},
{
"service": "Vanier Library",
"text": "2 PM to 2 PM"
},
{
"service": "Special Collections",
"text": "2 PM to 2 PM"
},
{
"Error": "Something went wrong. Make sure input date is properly formated: YYYY-MM-DD and not in the too distant future"
}
]
opendataConcordiaU commented 2 years ago

Yes, this is seems to working fine. Closing the issue