opendatacam / opendatacam-mobile

OpenDataCam mobile app for android
https://play.google.com/store/apps/details?id=com.opendatacam
MIT License
12 stars 3 forks source link

Data view : Display tiny label with emoji #12

Open tdurand opened 3 years ago

tdurand commented 3 years ago

Right now we are displaying 6 mobility classes, but ideally would be better to just display the 6 most counted classes depending on the data recorded... I'm testing on my desk and would love to see some laptop / coffee / chair OpenMojis ;-)

TODO:

b-g commented 3 years ago

RE: need to map all the COCO classes to an emoji in the config.json Where is the config.json file, couldn't find it in the repo? What about pulling the latest OpenMoji 13 version?

tdurand commented 3 years ago

yep, need to also update to the latest OpenMoji SVGs

there is not config.json in this repo, we use the one from the main repo.

Just need to complete the DISPLAY_CLASSES

https://github.com/opendatacam/opendatacam/blob/master/config.json#L24

The coco classes: "person", "bicycle", "car", "motorcycle", "airplane", "bus", "train", "truck", "boat", "traffic light", "fire hydrant", "stop sign", "parking meter", "bench", "bird", "cat", "dog", "horse", "sheep", "cow", "elephant", "bear", "zebra", "giraffe", "backpack", "umbrella", "handbag", "tie", "suitcase", "frisbee", "skis", "snowboard", "sports ball", "kite", "baseball bat", "baseball glove", "skateboard", "surfboard", "tennis racket", "bottle", "wine glass", "cup", "fork", "knife", "spoon", "bowl", "banana", "apple", "sandwich", "orange", "broccoli", "carrot", "hot dog", "pizza", "donut", "cake", "chair", "couch", "potted plant", "bed", "dining table", "toilet", "tv", "laptop", "mouse", "remote", "keyboard", "cell phone", "microwave", "oven", "toaster", "sink", "refrigerator", "book", "clock", "vase", "scissors", "teddy bear", "hair drier", "toothbrush"

b-g commented 3 years ago

Will do ... tomorrow.

b-g commented 3 years ago

Ok. Mapped all COCO classes to hexcodes (and OpenMoji) ... see https://docs.google.com/spreadsheets/d/1PuwHMTkRK5TMgS-xrN99U6Wnv8CoFT8nmvJW5sOIiWg/edit?usp=sharing (it might be a good idea to link this doc somewhere in the readme, as it gives a nice overview, where?).

What to do with the one e.g. parking meter, where there is no hexcode / no OpenMoji extra available? Maybe "missing font/char" https://openmoji.org/library/#search=missing&emoji=25A1?

b-g commented 3 years ago

PS. the config.json might hold a small bug. Check motorcycle vs. motorbike.

tdurand commented 3 years ago

nice thanks ! working on including this for next beta... and yes I think "missing font/char" is ok...

yes will add on the documentation here: https://github.com/opendatacam/opendatacam/blob/master/documentation/CONFIG.md#display-custom-classes

tdurand commented 3 years ago

got this implemented.. currently displaying the most counted classes, and if there is just one, display just one... makes things a bit clearer.. now I think should also add the label as the emoji sometimes isn't available + not necessary very clear

b-g commented 3 years ago

Yes to tiny labels. In case the the counter detail view is big enough I would also add a hint in the title e.g. "{counter-name} (top 6 classes)"