opendatacube / datacube-core

Open Data Cube analyses continental scale Earth Observation data through time
http://www.opendatacube.org
Apache License 2.0
493 stars 175 forks source link

Warn if non-eo3 dataset has eo3 metadata type #1523

Closed Ariana-B closed 6 months ago

Ariana-B commented 6 months ago

Reason for this pull request

The sole criteria for a dataset being recognised as an eo3 dataset is the inclusion of the eo3 schema in the definition. If the dataset is not considered eo3 due to a missing schema but is otherwise treated as eo3 due to the product metadata type, it can cause seemingly mysterious errors down the line, as seen on slack.

Proposed changes


📚 Documentation preview 📚: https://datacube-core--1523.org.readthedocs.build/en/1523/

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9fb8c8c) 91.75% compared to head (6e8fef0) 91.79%. Report is 4 commits behind head on develop.

Files Patch % Lines
datacube/index/memory/_datasets.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1523 +/- ## =========================================== + Coverage 91.75% 91.79% +0.04% =========================================== Files 132 132 Lines 14552 14624 +72 =========================================== + Hits 13352 13424 +72 Misses 1200 1200 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.