Expand search_returning() so that it covers search_summaries() use cases.
Deprecate search_summaries() and search_eager().
Deprecate source_filter on search() method.
Replace all internal calls to search_summaries() and search_returning() with search_returning() and plain old search().
Add archived argument to all search and count methods. (False/default - exclude archived datasets; None: include archived datasets; True: return/count archived datasets only)
Some internal cleanup of memory driver.
Backwards incompatible side-effects of this PR:
The datacube dataset search CLI command behaves differently for datasets with no location or multiple locations (now always one result per dataset)
The search_by_metadata() method used to include archived datasets - this was inconsistent with all other search methods and undocumented. Now honours the archived parameter, which defaults to False as for all other search methods.
[x] Tests added / passed
[x] Fully documented, including docs/about/whats_new.rst for all changes
Reason for this pull request
See EP13
Proposed changes
search_by_metadata.search_returning()so that it coverssearch_summaries()use cases.search_summaries()andsearch_eager().source_filteronsearch()method.search_summaries()andsearch_returning()withsearch_returning()and plain oldsearch().archivedargument to all search and count methods. (False/default - exclude archived datasets; None: include archived datasets; True: return/count archived datasets only)Backwards incompatible side-effects of this PR:
datacube dataset searchCLI command behaves differently for datasets with no location or multiple locations (now always one result per dataset)The
search_by_metadata()method used to include archived datasets - this was inconsistent with all other search methods and undocumented. Now honours the archived parameter, which defaults to False as for all other search methods.docs/about/whats_new.rstfor all changes