Closed SpacemanPaul closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.57%. Comparing base (
5b0d0c7
) to head (2c96d9f
). Report is 1 commits behind head on develop-1.9.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reason for this pull request
For complex queries (as can occur when using
search_returning
), SQLAlchemy was non-deterministically failing to resolve a join strategy. This was caused some tests to fail intermittently. A re-run (or 2, or 3) of the tests was usually sufficient to bypass but it shouldn't have been happening and needed to be addressed.Proposed changes
driver.postgis._fields
NativeField
s smart enough to generate anonclause
parameter for the SQLAjoin
function, and wire in to the query generation code.Running a temporary minimal test that triggered the issue, this change took us from failing roughly 1 run in 4 to not failing at all for 25+ sequential test runs.
docs/about/whats_new.rst
for all changes