Closed SpacemanPaul closed 4 months ago
Attention: Patch coverage is 91.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 85.43%. Comparing base (
e69ff50
) to head (325bb12
). Report is 35 commits behind head on develop-1.9.
Files with missing lines | Patch % | Lines |
---|---|---|
datacube/index/eo3.py | 91.66% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Worth noting that I have no idea what the point of rewriting lineage like this actually is.
Reason for this pull request
On indexing an eo3 dataset, the
prep_eo3()
method is called, which generates theextent
andgrid_spatial
sections from the grids already defined, and adds those new sections into the dataset metadata for storage, and also rewrites lineage metadata into a new format.If dataset metadata is copied directly from an existing ODC index, this "preparation" is already applied, and calling
prep_eo3()
on the dataset again fails with an ugly error.Proposed changes
Modify the
prep_eo3()
function so that it is idempotent. E.g. after this PR:prep_eo3(doc, **kwargs) == prep_eo3(prep_eo3(doc, **kwargs), **kwargs)
docs/about/whats_new.rst
for all changes