search

opendatacube / datacube-core

Open Data Cube analyses continental scale Earth Observation data through time
http://www.opendatacube.org
Apache License 2.0
505 stars 176 forks source link

Need better error reporting when constructing `GridSpec` #556

Closed Kirill888 closed 1 year ago

Kirill888 commented 6 years ago

Expected behaviour

Meaningful error message when user supplies GridSpec document with missing/misspelled information.

Actual behaviour

Code raises KeyError: latitude

Steps to reproduce the behaviour

Mismatched x,y vs longitude,latitude in either tile_size, resolution, origin (reported on Slack, supplying x,y for EPSG:4326 CRS).

Where

Code here should first check if correctly named keys are present and throw some Datacube error if not:

https://github.com/opendatacube/datacube-core/blob/a82de5c031d711043b5dedbb09b609de0d544a4f/datacube/model/__init__.py#L491-L493

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

omad commented 1 year ago

The plan is to deprecate GridSpec in v1.9 and remove it in v2, so this will no longer be relevant. Any errors will be via opendatacube/odc-geo: GeoBox and geometry utilities extracted from datacube-core.