search

opendatacube / datacube-core

Open Data Cube analyses continental scale Earth Observation data through time
http://www.opendatacube.org
Apache License 2.0
514 stars 177 forks source link

make_dataset shouldn't generate random id #613

Closed emmaai closed 4 years ago

emmaai commented 5 years ago

Expected behaviour

make_dataset should generate uuid according to some rules, which would enable tracing back to the data file(s)

Actual behaviour

uuid is generated randomly, doesn't show any information about the data file(s).

Kirill888 commented 5 years ago

make_dataset should allow customization of uuid generation through some mechanism:

https://github.com/opendatacube/datacube-core/blob/83bae20d2a2469a6417097168fd4ede37fd2abe5/datacube/model/utils.py#L184-L198

Currently random uuid is generated:

https://github.com/opendatacube/datacube-core/blob/83bae20d2a2469a6417097168fd4ede37fd2abe5/datacube/model/utils.py#L80-L84

We should not encourage random uuids (v4), instead we should use uuid v5 (namespace), using something like common prefix path as "name" part of uuid5.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.