search

opendatacube / datacube-explorer

Web-based exploration of Open Data Cube collections
Apache License 2.0
54 stars 31 forks source link

pre-commit-config: do not reformat schemas #548

Closed pjonsson closed 7 months ago

pjonsson commented 7 months ago

Reformatting will give spurious differences after running the update.sh script.

:books: Documentation preview :books:: https://datacube-explorer--548.org.readthedocs.build/en/548/

pjonsson commented 7 months ago

I'm not sure how to test this without doing an actual update and see what the precommit bot does, so I might have missed something. Considering #546, I don't want to change things too much.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d7fa351) 85.88% compared to head (dd13e34) 85.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #548 +/- ## ======================================== Coverage 85.88% 85.88% ======================================== Files 26 26 Lines 3457 3457 ======================================== Hits 2969 2969 Misses 488 488 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

omad commented 7 months ago

Sorry if I'm explaining things you already know...

Pre-commit should be installed locally, and then pre-commit install should be run for within each repo using it.

After doing that, it's possible to do a "test run" using pre-commit run --all-files, which is AFAIK what the pre-commit service does.

pjonsson commented 7 months ago

I know very little about best practices for interpreted languages, thank you for explaining!