opendatacube / datacube-explorer

Web-based exploration of Open Data Cube collections
Apache License 2.0
54 stars 31 forks source link

Revert previous auto-modernise commits #587

Closed jeremyh closed 2 months ago

jeremyh commented 2 months ago

Some changes by shed have broken the semantics of sqlalchemy queries (see https://github.com/opendatacube/datacube-explorer/issues/581)

I haven't retested the original issues, this is a just reverting some clear errors.

Note that ruff has made some changes of its own to match its black-like formatting, but they're minor


📚 Documentation preview 📚: https://datacube-explorer--587.org.readthedocs.build/en/587/

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.32%. Comparing base (aa0d9f3) to head (ed70628). Report is 23 commits behind head on develop.

Files Patch % Lines
cubedash/warmup.py 0.00% 2 Missing :warning:
cubedash/_stac.py 90.00% 1 Missing :warning:
cubedash/generate.py 66.66% 1 Missing :warning:
cubedash/summary/_extents.py 66.66% 1 Missing :warning:
cubedash/summary/_schema.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #587 +/- ## =========================================== + Coverage 86.29% 86.32% +0.03% =========================================== Files 26 26 Lines 3451 3466 +15 =========================================== + Hits 2978 2992 +14 - Misses 473 474 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.