opendatacube / datacube-explorer

Web-based exploration of Open Data Cube collections
Apache License 2.0
56 stars 31 forks source link

Dockerfile: fail on errors #596

Closed pjonsson closed 3 months ago

pjonsson commented 4 months ago

Merge a couple of layers to slightly reduce the image size, and rewrite the if-then-else into short-circuiting tests followed by commands chained together with &&. This makes building the image fail if something is wrong, instead of giving strange errors when running the tests.

The issue was discovered in the initial push of #588 that passed the build phase, but failed the tests.


📚 Documentation preview 📚: https://datacube-explorer--596.org.readthedocs.build/en/596/

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.18%. Comparing base (aa0d9f3) to head (eb9e481). Report is 119 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #596 +/- ## =========================================== - Coverage 86.29% 86.18% -0.12% =========================================== Files 26 26 Lines 3451 3466 +15 =========================================== + Hits 2978 2987 +9 - Misses 473 479 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.