search

opendatacube / datacube-k8s-eks

Deploy a production scale datacube cluster on AWS using EKS
Apache License 2.0
21 stars 14 forks source link

cognito - support token validity configuration #268

Closed NikitaGandhi closed 3 years ago

NikitaGandhi commented 3 years ago

Any PRs will require running terraform fmt -recursive successfully first. Please install terraform version v0.13.5 on your local setup for this activity.

Why this change is needed

Describe why this change is needed, what issues it will fix and the benefits the change will add

cognito - support token validity configuration. This is per app-client configuration and it's default is set to below:

    token_validity_units = {
      access_token  = "minutes"
      id_token      = "minutes"
      refresh_token = "days"
    }
    access_token_validity  = 60
    id_token_validity      = 60
    refresh_token_validity = 30

Negative effects of this change

Will making this change break or change an existing functionality? flag it here

It can impact so make sure either go with defaults or override to your configuration.

NikitaGandhi commented 3 years ago

can resolve issue #245 and #265

NikitaGandhi commented 3 years ago

We have tested and ready to merge this PR

mmochan commented 3 years ago

LGTM!