Closed squireg closed 2 years ago
PR is fine as is but I would be good to add vars for the two poll interval parameters as well whilst we are at it. 1 min is pretty aggressive.
Added flux_{git,registry}_poll_interval variables with default values that match the previously hard coded behaviour.
Expose the flux git timeout configuration option as a terraform module variable, with a default value matching the default set in the flux helm chart.
Expose the flux git poll interval and flux registry poll interval configuration options as terraform module variables. Default values are set to the values previously hard coded in this module.
Why this change is needed
The default timeout (20s) allowed for flux to fetch git repositories during reconciliation is not long enough for some of our larger/slower repos. The flux helm chart already exposes the timeout setting so this change makes that available to users of this tf module.
The hard coded poll intervals (1m) were more aggressive than we needed or wanted. This change allows users to configure the options appropriately.
Negative effects of this change