search

opendatacube / datacube-k8s-eks

Deploy a production scale datacube cluster on AWS using EKS
Apache License 2.0
21 stars 14 forks source link

Terraform aws provider v4.0.0 updates #283

Closed NikitaGandhi closed 2 years ago

NikitaGandhi commented 2 years ago

Any PRs will require running terraform fmt -recursive successfully first. Please install terraform version > v0.15 on your local setup for this activity.

Why this change is needed

Describe why this change is needed, what issues it will fix and the benefits the change will add

The recent release of terraform-aws-provider v4.0.0 has remove support for some of the aws_s3_bucket resource configurations. This PR update/fix those changes. Refer release v4.0.0 for more detail.

Negative effects of this change

Will making this change break or change an existing functionality? flag it here

Reapply bucket configurations.

jmettes commented 2 years ago

The Terraform upgrade guide might be useful to other reviewers to refer to: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade

jmettes commented 2 years ago

Looks good! I'll update the pinned v3 providers after this is merged.