Any PRs will require running terraform fmt -recursive successfully first. Please install terraform version > v0.15 on your local setup for this activity.
Why this change is needed
Describe why this change is needed, what issues it will fix and the benefits the change will add
We are in the process of upgrading k8s cluster from 1.20 to 1.21. A recommendation has been made to migrate away from dockerd and make use of containerd. (see https://marcincuber.medium.com/amazon-eks-upgrade-journey-from-1-20-to-1-21-caf1475deaa4 for more information). To do this, we need to pass a parameter to bootstrap.sh (i.e. --container-runtime containerd). Looking at the current version of the odc_eks module, there is no mechanism to achieve this. I am therefore proposing the addition of a mechanism to pass extra parameters to bootstrap.sh. This can be achieved by including a variable extra_bootstrap_args (as it is currently done for kubelet args). I have implemented the change in the fork and now requesting for changes to be merged back.
Negative effects of this change
Will making this change break or change an existing functionality? flag it here
It will not affect anything else as we are maintaining all the current args to bootstrap.sh and just adding extra_bootstrap_args which will be blank by default.
--extra_bootstrap_args
Any PRs will require running
terraform fmt -recursivesuccessfully first. Please install terraform version >v0.15on your local setup for this activity.Why this change is needed
We are in the process of upgrading k8s cluster from 1.20 to 1.21. A recommendation has been made to migrate away from dockerd and make use of containerd. (see https://marcincuber.medium.com/amazon-eks-upgrade-journey-from-1-20-to-1-21-caf1475deaa4 for more information). To do this, we need to pass a parameter to bootstrap.sh (i.e. --container-runtime containerd). Looking at the current version of the odc_eks module, there is no mechanism to achieve this. I am therefore proposing the addition of a mechanism to pass extra parameters to bootstrap.sh. This can be achieved by including a variable extra_bootstrap_args (as it is currently done for kubelet args). I have implemented the change in the fork and now requesting for changes to be merged back.
Negative effects of this change
It will not affect anything else as we are maintaining all the current args to bootstrap.sh and just adding extra_bootstrap_args which will be blank by default.