Closed alexgleith closed 2 weeks ago
Attention: Patch coverage is 63.63636%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 93.28%. Comparing base (
5a0fbf4
) to head (f298a2e
). Report is 6 commits behind head on develop-1.9.
Files with missing lines | Patch % | Lines |
---|---|---|
datacube_ows/startup_utils.py | 42.85% | 4 Missing :warning: |
@alexgleith if I understand your description, GetCapabilities will return broken results without this. Does this already work for the main branch, or should this commit also be merged there?
Hey @pjonsson this was merged into the main branch too.
@alexgleith are you sure about that? If I git grep PROXY_FIX
on latest master, I get no hits.
@alexgleith are you sure about that?
Nope, not sure! I think it must have been the other fix about cache-control headers that was merged into both.
Happy to review a PR that adds this to the 1.8 branch.
This is a low-risk and high-reward feature that adds another environment variable that turns on the "proxy_fix" middleware, which ensures the app understands what URLs it should return as part of the getCaps and other responses.
Tested in production for DE Pacific.
π Documentation preview π: https://datacube-ows--1085.org.readthedocs.build/en/1085/