search

opendatacube / datacube-stats

Data Cube Temporal Statistic Tools
http://www.ga.gov.au/about/projects/geographic/digital-earth-australia
Other
22 stars 6 forks source link

Fix check_code.sh failures #180

Closed GypsyBojangles closed 5 years ago

GypsyBojangles commented 5 years ago

On the 27th of February, pylint 2.3 was released, introducing a new no-else-raise flag. This complains about if statements of a particular structure that contain raise directives: http://pylint.pycqa.org/en/stable/whatsnew/2.3.html?highlight=no-else-raise

After discussion with @omad, we have opted to implement a pylint whitelist as opposed to a blacklist. To achieve this, I copied pylintrc from digitalearthau so that we explicitly enable flags we care about. Also, updated readme to use correct badges and removed coveralls badge.

codecov[bot] commented 5 years ago

Codecov Report

Merging #180 into master will increase coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #180      +/-   ##
=========================================
+ Coverage   54.48%   54.5%   +0.02%     
=========================================
  Files          21      21              
  Lines        2410    2409       -1     
=========================================
  Hits         1313    1313              
+ Misses       1097    1096       -1
Impacted Files Coverage Δ
datacube_stats/utils/__init__.py 39.39% <0%> (+0.19%) :arrow_up:
datacube_stats/main.py 40.04% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b06c809...95aa99e. Read the comment docs.