search

opendatacube / eo-datasets

Easily write, validate and convert EO datasets and metadata.
Apache License 2.0
49 stars 26 forks source link

Update ls4-7 band aliases #313

Closed Ariana-B closed 10 months ago

Ariana-B commented 10 months ago

Recently downloaded ls7 l1 c2 scenes crash Landsat packaging during the yaml generation phase due to updated band mappings in new collection. Add missing band aliases to mapping. Also update github actions in docker workflow, and update pystac and jsonschema versions.

jeremyh commented 10 months ago

Thanks for looking into this Ariana!

It looks like the test failures are unrelated to the change. A dependency may have broken:

self = <pystac.validation.stac_validator.JsonSchemaSTACValidator object at 0x7fd31a235f40>
schema_uri_map = None

    def __init__(self, schema_uri_map: Optional[SchemaUriMap] = None) -> None:
        if not HAS_JSONSCHEMA:
>           raise ImportError("Cannot instantiate, requires jsonschema package")
E           ImportError: Cannot instantiate, requires jsonschema package
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9d4a391) 84.78% compared to head (2be9b43) 84.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #313 +/- ## ======================================== Coverage 84.78% 84.78% ======================================== Files 26 26 Lines 4410 4410 ======================================== Hits 3739 3739 Misses 671 671 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ariana-B commented 10 months ago

@jeremyh tests are passing now