add missing libs, change dea-proto install mode

opendatacube / jupyterhub

JupyterHub Docker Image that supports OpenDataCube

Apache License 2.0

3 stars 2 forks source link

add missing libs, change dea-proto install mode #5

Closed Kirill888 closed 5 years ago

Kirill888 commented 5 years ago

Use dea-proto wheels from https://packages.dea.gadevs.ga/
Add missing dask_labextension
Make sure terminal launches bash
Add nbdime for notebook diffing
Add tini

alexgleith commented 5 years ago

I'm not quite sure if this will get automatically deployed to the DEA and Africa Sandboxes. (I should know this better, but currently I'm a bit fuzzy.)

These changes look good, but I'd like to wait until next week until we merge it.

Kirill888 commented 5 years ago

@alexgleith why does this thing install and run jupyterhub? I thought jupyterhub runs externally, when you run default command there is no way to login anyway.

alexgleith commented 5 years ago

This is the pattern for Dockerfiles, and it's what the Jupyterhub folks do, see: https://github.com/jupyterhub/jupyterhub/blob/master/Dockerfile