search

opendatacube / odc-geo

GeoBox and geometry utilities extracted from datacube-core
https://odc-geo.readthedocs.io/en/latest/
Apache License 2.0
80 stars 12 forks source link

Fix type hint backward compatibility #154

Closed fbunt closed 4 months ago

fbunt commented 4 months ago

Fixes #153

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.32%. Comparing base (6af5d0c) to head (663af37). Report is 29 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #154 +/- ## =========================================== + Coverage 95.26% 95.32% +0.05% =========================================== Files 31 31 Lines 5323 5451 +128 =========================================== + Hits 5071 5196 +125 - Misses 252 255 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Kirill888 commented 4 months ago

@fbunt thanks, but can you please fix this via import from future instead, like here for example:

https://github.com/opendatacube/odc-geo/blob/72e873ad49fe73ad6a9349f9853003dbcb21e181/odc/geo/_xr_interop.py#L8

SpacemanPaul commented 4 months ago

I see setup.cfg still advertises support for Python >=3.8.

This should probably be bumped to at least 3.9 as 3.8 is now end-of-lifed and unmaintained.

fbunt commented 4 months ago

@Kirill888 Oh I didn't know about that one, thanks! Done.