search

opendatacube / odc-stac

Load STAC items into xarray Datasets.
Apache License 2.0
140 stars 20 forks source link

populate uris in eo3 ds with stac url #152

Closed emmaai closed 7 months ago

emmaai commented 7 months ago

As the title. Make a eo3 dataset with location/uris populated by stac url, which could to be loaded with dc.load.

github-actions[bot] commented 7 months ago

🚀 Deployed on https://f6d43600145741f0--odc-stac-docs.netlify.app

emmaai commented 7 months ago

The code changes look sensible enough to me, but I would like to see test coverage.

The coverage hang there https://github.com/opendatacube/odc-stac/actions/runs/8641742492/job/23691767514#step:7:28

emmaai commented 7 months ago

Sorry I should have read more into the code and understand what's in stac items before making the change. it clearly states here https://github.com/opendatacube/odc-stac/blob/407db82799aaf823a4f5c1d65bc89eb0357dd06d/odc/stac/_mdtools.py#L701, that the href of stac would be reserved.