Closed emmaai closed 4 months ago
Attention: Patch coverage is 95.75472%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 78.00%. Comparing base (
36a7c3d
) to head (cf09d9a
). Report is 3 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
odc/stats/plugins/lc_fc_wo_a0.py | 91.66% | 6 Missing :warning: |
odc/stats/_algebra.py | 92.50% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have marked the awful name as an issue to be resolved along development progressing
The logic is described as follows:
valid:=0x000x_xx00
&ue < 30
wherex
means any value of{0, 1}
wet:=0x1000_0x00
, hence the valid wet+dry pixels arewet | valid
nodata=np.nan
wet
band for further classification of veg vs. non-vegveg:= pv>bs | npv > bs & wet <= 0
, wherewet > 0
implies that at least half of observations in a month pixels beingwet
, otherwise non-veg.nan := nodata
.nan
(ornodata
) is considered to be neither veg nor non-veg. Though it doesn't break consecutiveness either, e.g., a sequence of{1, nan, 1, 1}
is deemed as3
consecutive months, where1
indicates veg, while a sequence of{1, 0, 1, 1}
is deemed as2
consecutive months as0
breaks consecutiveness and hence number is reset.Note:
pylint hook in pre-commit ci is out of date and it failed in python 3.12. I don't see any way to fix it, hence made pylint a local hook and skip in ci.