Closed emmaai closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.29%. Comparing base (
0aa9773
) to head (9bba420
). Report is 2 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I changed my mind on where to fix gm
nodata
issue, based on the following reasons:nodata
for extra bands other than the input bands.nodata
is defined in production definition yaml. All datasets should respect and follow the same definition such thatdc.load
andrioxarray.open
will result the samenodata
information. For future improvement ref issue #131count
beinguint16
in GeoTIFF whileint16
in product def, which results inint16
indc.load
whileuint16
with other toolsnodata=nan
for float when generating overviews either. Thus it'd be good that we honournodata
definition every level. In this PR, I allowednodata
not defined forcount
band because of a) data type discrepancy mentioned above, b)nodata
not presents in raster hence no trouble atmI decide to address the coding issues later while keep the path clear for now.