search

opendatacube / odc-stats

Statistician is a framework of tools for generating statistical summaries of large collections of EO data managed in an ODC instance.
Apache License 2.0
9 stars 4 forks source link

Fix xarray groupby #83

Closed emmaai closed 1 year ago

emmaai commented 1 year ago

Changes

I don't have a sensible way to test the docker image against the current code since it's supposed to be a regression test and nothing should be broken. Maybe I shouldn't have updated the docker image in this pr. I'll leave the docker image test failed until next pr specially on it.

woodcockr commented 1 year ago

@emmaai I can’t review this PR (outside my knowledge of the code) but I did want to say thanks for getting on top of this groupby issue and I’m looking forward to the update!

codecov[bot] commented 1 year ago

Codecov Report

Base: 75.27% // Head: 75.57% // Increases project coverage by +0.30% :tada:

Coverage data is based on head (d694fb4) compared to base (8f564b2). Patch coverage: 97.29% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #83 +/- ## =========================================== + Coverage 75.27% 75.57% +0.30% =========================================== Files 33 33 Lines 3134 3169 +35 =========================================== + Hits 2359 2395 +36 + Misses 775 774 -1 ``` | [Impacted Files](https://codecov.io/gh/opendatacube/odc-stats/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatacube) | Coverage Δ | | |---|---|---| | [odc/stats/io.py](https://codecov.io/gh/opendatacube/odc-stats/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatacube#diff-b2RjL3N0YXRzL2lvLnB5) | `32.37% <0.00%> (+0.13%)` | :arrow_up: | | [tests/test\_fc\_percentiles.py](https://codecov.io/gh/opendatacube/odc-stats/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatacube#diff-dGVzdHMvdGVzdF9mY19wZXJjZW50aWxlcy5weQ==) | `100.00% <100.00%> (ø)` | | | [tests/test\_gm\_ls\_bitmask.py](https://codecov.io/gh/opendatacube/odc-stats/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatacube#diff-dGVzdHMvdGVzdF9nbV9sc19iaXRtYXNrLnB5) | `100.00% <100.00%> (ø)` | | | [tests/test\_pq\_bitmask.py](https://codecov.io/gh/opendatacube/odc-stats/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatacube#diff-dGVzdHMvdGVzdF9wcV9iaXRtYXNrLnB5) | `100.00% <100.00%> (ø)` | | | [tests/test\_wofs.py](https://codecov.io/gh/opendatacube/odc-stats/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatacube#diff-dGVzdHMvdGVzdF93b2ZzLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatacube). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatacube)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.