opendatadiscovery / odd-platform

First open-source data discovery and observability platform. We make a life for data practitioners easy so you can focus on your business.
https://opendatadiscovery.org
Apache License 2.0
1.16k stars 96 forks source link

Tags are not being cascaded for the terms which are linked to the Data-entity Structure. #1688

Closed mavenzer closed 2 weeks ago

mavenzer commented 4 weeks ago

With the recent release of ODD-Platform (0.27.0), we have observed an unusual behavior when linking terms to the data-entity structure. Specifically, the tags associated with the terms are not being carried over, despite the terms themselves having tags.

For additional context, please refer to the attached screenshots. Notably, the tags are not visible at the term level.

tag

For the data-Entity where we have linked the terms with the tags. We cannot see the tags being cascaded down to the terms.

date-e

terms

RamanDamayeu commented 3 weeks ago

Hi @mavenzer! I just wanted to clarify whether the functionality expectations match.

In the release 0.26.0, we added the ability to assign a term to another term directly or through definition. So now we can essentially build a “knowledge graph” by referencing from one term to another (and with some additional context if we use reach text in definitions). And we can still specify terms at the date entity level. But no tags were added to the terms. This functionality to indicate a tag on a term is not yet available at all...

clintjb commented 3 weeks ago

Hi @RamanDamayeu Maybe just to jump in - totally understand the term to term linking... Issue is it seems the tag area has now been removed (see screenshot and highlighted area) previously it was able to see which tags were associated with that term as well as edit / add / remove etc - this area now no longer exists - hope this is a little clearer

image

RamanDamayeu commented 3 weeks ago

Yeah, my bad!!! You're totally right! There were tags on terms I've just forgotten about it... The system is even better :) It's a bug that tags are hidden in UI for terms now but actually they still exist.

We'll fix it in next coming days.

Vladysl commented 3 weeks ago

PR - https://github.com/opendatadiscovery/odd-platform/pull/1689 merged

mavenzer commented 2 weeks ago

Thanks a lot