search

opendatahub-io-contrib / data-mesh-pattern

Data Mesh Pattern
https://opendatahub-io-contrib.github.io/data-mesh-pattern
Apache License 2.0
28 stars 15 forks source link

Notebook image for Data Mesh is not working #84

Closed caldeirav closed 1 year ago

caldeirav commented 1 year ago

The custom notebook image for Data Mesh is not being started successfully from the RHODS console:

Image

Image

There are issues with the image build.

avinashsingh77 commented 1 year ago

Saw this error in workbook pod:

[E 2023-09-04 07:04:18,118.118] Error loading schemas for SchemasProvider 'code-snippets' - Descriptors cannot not be created directly.If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.If you cannot immediately regenerate your protos, some other possible workarounds are: 1. Downgrade the protobuf package to 3.20.x or lower. 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

Added the following to supply-chain/elyra/datamesh/Dockerfile as a workaround

RUN /opt/app-root/bin/pip3 install protobuf==3.20.0 && \
    export PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python

Managed to launch the workbench with datamesh image

Awaiting permanent resolution and will then implement the same

avinashsingh77 commented 1 year ago

Got this from ODH team - you may just keep the protobuf downgrade to 3.20.x and leave env var PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION to not impact the performance Removed the line which was setting PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION from https://gitlab-ce.apps.cluster-djbb6.djbb6.sandbox2519.opentlc.com/rainforest/data-mesh-pattern/-/blob/main/supply-chain/elyra/datamesh/Dockerfile

avinashsingh77 commented 1 year ago

As tested by @caldeirav , server is now starts okay with custom datamesh image