search

opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.
16 stars 31 forks source link

Add JH idle culler and deps to pipfile #103

Closed 4n4nd closed 3 years ago

4n4nd commented 3 years ago

Related Issues and Dependencies

Related PR: https://github.com/opendatahub-io/odh-manifests/pull/457

This introduces a breaking change

This Pull Request implements

Adds the following packages (source)

jupyterhub-idle-culler = "==1.1"
pycurl= "==7.43.0.6"

to the pipfile and update the pipfile.lock as well

Description

This will enable the image quay.io/opendatahub/jupyterhub-img to start the JH pod culler process which can be used as a JH service. If we add this package in the jupyterhub-img image, we won't have to maintain a separate image for the culler (ref PR).

Tested the image build using:

s2i build . quay.io/odh-jupyterhub/jupyterhub:v3.5.3 jh:latest

maroroman commented 3 years ago

@4n4nd I am adding the dependencies as part of this patch: https://github.com/opendatahub-io/jupyterhub-odh/pull/97

4n4nd commented 3 years ago

Ah okay :+1: