opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.
16 stars 31 forks source link

Add traefik dependancy #104

Closed maulikjs closed 3 years ago

maulikjs commented 3 years ago

Related Issues and Dependencies

https://issues.redhat.com/browse/ODH-421

This introduces a breaking change

This Pull Request implements

This Pull request installs the jupyterhub-traefik-proxy which will be used to write the routes to a .toml file in a configmap and connect to the external Traefik proxy.

maulikjs commented 3 years ago

/hold

LaVLaS commented 3 years ago

/lgtm

I can't confirm that it works but the changes appear to be valid

LaVLaS commented 3 years ago

/deploy

vpavlin commented 3 years ago

/deploy

maulikjs commented 3 years ago

/deploy

vpavlin commented 3 years ago

/deploy

vpavlin commented 3 years ago

lgtm