opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.
16 stars 31 forks source link

Add config option to define behaviour when no groups are set #110

Closed vpavlin closed 2 years ago

vpavlin commented 2 years ago

Related Issues and Dependencies

This introduces a breaking change

This Pull Request implements

This PR adds an environment variable JUPYTERHUB_GROUPS_DEFAULT_DENIED which defines if users should be allowed to use JupyterHub if no groups are defined.

By default all users with OpenShift login are allowed

By setting this env var to true you make sure all users are by default denied access, unless the groups are configured and the users belong to given groups

Description

anishasthana commented 2 years ago

While testing, if we set JUPYTERHUB_GROUPS_DEFAULT_DENIED to "true" and didn't have any groups created, JupyterHub gets stuck in a crashloop. Is this behaviour expected?

harshad16 commented 2 years ago

/retest