Improvements in the jsp-api to support custom env vars in Jupyterhub servers in a separate namespace
Description
After the introduction of the custom notebook namespaces in RHODS, the env vars form in the spawner UI stopped working. This PR fixes the way jsp-api is started with a new internal env var names NOTEBOOK_NAMESPACE to create the configmap and secrets in that custom namespace (see https://github.com/opendatahub-io/jupyterhub-singleuser-profiles/pull/174).
Testing instructions
Build an image containing the code from this PR and the jupyterhub-singleuser-profiles PR (see the reference above)
Deploy RHODS Jupyterhub from the built image
Access JH spawner UI
Create any environment variable
Create another environment variable, but mark as Secret
Click Start Server button
After the Jupyter Lab UI is shown, create a simple notebook and print os.environ object
Check if the custom env var sis listed in the code output
Stop the server and go to the Spawner page again
Check if the custom env vars are showing in the form
Related Issues and Dependencies
RHODS-1641
This introduces a breaking change
This Pull Request implements
Improvements in the jsp-api to support custom env vars in Jupyterhub servers in a separate namespace
Description
After the introduction of the custom notebook namespaces in RHODS, the env vars form in the spawner UI stopped working. This PR fixes the way jsp-api is started with a new internal env var names
NOTEBOOK_NAMESPACE
to create the configmap and secrets in that custom namespace (see https://github.com/opendatahub-io/jupyterhub-singleuser-profiles/pull/174).Testing instructions
jupyterhub-singleuser-profiles
PR (see the reference above)Start Server
buttonos.environ
object