opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.
16 stars 31 forks source link

Fix env var placement with custom jupyter notebooks namespace #111

Closed rimolive closed 3 years ago

rimolive commented 3 years ago

Related Issues and Dependencies

RHODS-1641

This introduces a breaking change

This Pull Request implements

Improvements in the jsp-api to support custom env vars in Jupyterhub servers in a separate namespace

Description

After the introduction of the custom notebook namespaces in RHODS, the env vars form in the spawner UI stopped working. This PR fixes the way jsp-api is started with a new internal env var names NOTEBOOK_NAMESPACE to create the configmap and secrets in that custom namespace (see https://github.com/opendatahub-io/jupyterhub-singleuser-profiles/pull/174).

Testing instructions

vpavlin commented 3 years ago

lgtm..we need to update JSP first though and ideall do the Pipfile update as part of this PR

vpavlin commented 3 years ago

/retest

vpavlin commented 3 years ago

CI is slow today, I rebuilt locally and checked the dependency is there, which was the last change. Merging