Set notebook namespace to None if empty

opendatahub-io-contrib / jupyterhub-odh

Example JupyterHub deployment using OpenShift OAuth authenticator.

16 stars 31 forks source link

Set notebook namespace to None if empty #114

Closed vpavlin closed 3 years ago

vpavlin commented 3 years ago

Related Issues and Dependencies

…

This introduces a breaking change

[ ] Yes
[x] No

This Pull Request implements

Checks implemented for setting notebook namespace require it to be None to set default namespace

If the NOTEBOOK_NAMESPACE env var is set, but is empty string, default namespace is not set and the OpenShift API calls are trying to get the resources on cluster level.

Description

LaVLaS commented 3 years ago

/lgtm

Looks good to me

rimolive commented 3 years ago

/lgtm